Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lang files' loading doesn't work on Android #40132

Closed
RedShakespeare opened this issue May 4, 2020 · 7 comments
Closed

Lang files' loading doesn't work on Android #40132

RedShakespeare opened this issue May 4, 2020 · 7 comments
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. OS: Android Issues related to Android operating system Translation I18n

Comments

@RedShakespeare
Copy link
Contributor

Describe the bug

In Settings-Interface-Language there are only English/system language two choices.

Steps To Reproduce

  1. Choose Settings and switch to Interface tab.

Expected behavior

? needless to say

Screenshots

Screenshot_2020-05-04-18-24-39-90_6fe8938556442e3d4f710ab4f9a16601

Versions and configuration

  • OS: Android
  • Game Version: 0.E-1726-g0c4d9b2(build 10620 and after)

Additional context

What happened?

@RedShakespeare RedShakespeare changed the title All languages lost except English All languages missing except English May 4, 2020
@RedShakespeare
Copy link
Contributor Author

RedShakespeare commented May 4, 2020

.mo files are still there but none of them is loaded

@ZhilkinSerg
Copy link
Contributor

Probably related to #40056

@ZhilkinSerg ZhilkinSerg added <Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. OS: Android Issues related to Android operating system Translation I18n labels May 4, 2020
@jbytheway
Copy link
Contributor

Indeed; I guess the logic @akirashirosawa used in #40056 doesn't work on Android. Is something different about the directory layout there?

@RedShakespeare
Copy link
Contributor Author

No...just underestimated the difficulty. Still need help.

@RedShakespeare RedShakespeare changed the title All languages missing except English Lang files' loading doesn't work on Android May 9, 2020
@RedShakespeare
Copy link
Contributor Author

RedShakespeare commented May 9, 2020

5 days have passed but still no fixes...
Many complaints in local social media groups...

Still, don't understand why this #40056 doesn't work...

@anothersimulacrum
Copy link
Member

anothersimulacrum commented May 9, 2020

Could it be this:

What happens is that PATH_INFO::langdir() is called at include-time, before PATH_INFO::set_standard_filenames() is called. That means that langdir_value = "", which means that the CWD will be scanned instead of the correct lang directory.

This is not really problematic if the current working directory is the game root (i.e. via cataclysm-launcher), but the game used to start fine directly from the binary and I think this is not expected behavior.

From #40356

@RedShakespeare
Copy link
Contributor Author

Fixed by #40377 .
Thx a million.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Info / User Interface Game - player communication, menus, etc. OS: Android Issues related to Android operating system Translation I18n
Projects
None yet
Development

No branches or pull requests

4 participants