Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle Welding Rig... Not enough charge #40203

Closed
fallout2077 opened this issue May 5, 2020 · 12 comments · Fixed by #40399
Closed

Vehicle Welding Rig... Not enough charge #40203

fallout2077 opened this issue May 5, 2020 · 12 comments · Fixed by #40399
Assignees
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions

Comments

@fallout2077
Copy link

When trying to use the Vehicle Welding Rig the game tells me that the tool doesn't have enough charge, despite being installed in a vehicle with 100% charge. I am using the latest experimental build 10628.

@Resok
Copy link
Contributor

Resok commented May 5, 2020

I'm seeing this also with the Vehicle forge rig.

@Resok
Copy link
Contributor

Resok commented May 5, 2020

To provide a bit more detail, this was with an old save - I'm no longer able to use the welding rig, forge rig, etc. They do not appear to be showing up as valid options for either crafting or vehicle mechanics interactions.

I can attach a save if it would help track things down.

@DillonSimeone
Copy link
Contributor

I'm having the same issue too.

Can't use the welder.

image

Unuseable for crafting too.

image

Batteries have plenty of power in them.
image

You can grab my saves and mods from this different issue to quickly test it. That save still have the welding rig installed instead of the masterforge I made and installed to try to bypass this bug.

#40154

@DillonSimeone
Copy link
Contributor

It appears that the nested update broke all of this somehow.

Strange thing, hotplates works just fine.

image

@Resok
Copy link
Contributor

Resok commented May 5, 2020

You're right, Hotplates are fine. Edited my previous comment.

@fallout2077
Copy link
Author

I'm seeing this also with the Vehicle forge rig.

There isn't even an option for me to use the forge rig when examining it.

@mrkybe
Copy link
Contributor

mrkybe commented May 6, 2020

Can confirm, ran into the same issue.

@Night-Pryanik Night-Pryanik added <Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions labels May 7, 2020
@Resok
Copy link
Contributor

Resok commented May 9, 2020

I did some debugging of this issue today and figured out that the core issue.

Basically inventory::form_from_map() creates a psudo item for the vehicle part it finds and assigns charges to the top level item, but no contents or magazines. Looking at the same kind of item data from a functioning welding rig, it has no charges at the top level - but instead a magazine that contains a charge.

@fallout2077
Copy link
Author

I did some debugging of this issue today and figured out that the core issue.

Basically inventory::form_from_map() creates a psudo item for the vehicle part it finds and assigns charges to the top level item, but no contents or magazines. Looking at the same kind of item data from a functioning welding rig, it has no charges at the top level - but instead a magazine that contains a charge.

Wow, amazing work investigating the issue... I wouldn't have even known where to begin to try and find out what was causing the bug. Thank you for devoting time and effort to this issue!

@Resok
Copy link
Contributor

Resok commented May 9, 2020

Validated a quick fix for one half of the problem (charge was being set on the root item, and no 'magazine' was being created with charge). Looking into the other half.

@fallout2077
Copy link
Author

Validated a quick fix for one half of the problem (charge was being set on the root item, and no 'magazine' was being created with charge). Looking into the other half.

Hopefully your fix gets committed sooner rather than later... it's the only thing stopping me and many other players from playing the darn game.

@fallout2077
Copy link
Author

I figured I'd state here that, with the fix, I can use the vehicle welding rig as an arc welder in crafting recipes, but I still see the "not enough charges" message whenever I try to use the welder directly from the examine menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants