Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

items dropped by npcs before recruited still considered stealing if picked up #40218

Open
Killa3999 opened this issue May 5, 2020 · 1 comment
Labels
<Bug> This needs to be fixed Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! NPC / Factions NPCs, AI, Speech, Factions, Ownership

Comments

@Killa3999
Copy link
Contributor

Killa3999 commented May 5, 2020

Items dropped by npcs before being recruited by the player will still show a warning when examined

When an npc drops items, they are marked as owned by an npc, and picking them up is considered stealing. But once the npc is recruited by the player, the items dropped are still owned by an npc, and picking them up produces a warning that it would be considered stealing to take them.

Steps To Reproduce

  1. Npc drops items
  2. Recruit npc
  3. Examine dropped items

Expected behavior

Items dropped, like everything the npc had in their inventory, are readily usable and belong to the player, or are not owned at all.

Screenshots

image

Versions and configuration

(actual version used during crash was g70f064a)
d

  • OS: Windows
    • OS Version: 10.0 1909
  • Game Version: 0.E-1783-g3ba1852 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    C.R.I.T Expansion Mod [crt_expansion],
    Dark Days Ahead: Lua [dda-lua],
    Dark Days Ahead: Lua (Fun) [dda-lua-fun],
    Dark Days Ahead: Lua (Items) [dda-lua-items],
    Dark Days Ahead: Lua (Traits) [dda-lua-traits],
    Magiclysm [magiclysm],
    Bootleg Walkers [Bootleg_Walkers],
    Gun Cotton [guncotton],
    Packaging [Packaging],
    Mining Mod [Mining_Mod],
    More Survivor Stuff [more_survivor_stuff],
    Jury-Rigged Robots [jury_rigged_robots],
    Fuji's Military Profession Pack [fuji_mpp],
    Mutation Changes [Mutation_Changes],
    SpeedyDex [speedydex],
    Stats Through Kills [stats_through_kills],
    Stats Through Skills [StatsThroughSkills],
    Alternative Map Key [alt_map_key],
    More City Locations [cityside]
    ]

Additional context

0.E-1783-g70f064a
Crashed when trying to load:
Durand.zip

crash.log

Updated version 0.E-1783-g3ba1852 and loaded:

Durand.zip

(debug log is on updated version and not when game crashed)
debug.log

@Night-Pryanik Night-Pryanik added the NPC / Factions NPCs, AI, Speech, Factions, Ownership label May 7, 2020
@stale
Copy link

stale bot commented Jun 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jun 6, 2020
@anothersimulacrum anothersimulacrum added the <Bug> This needs to be fixed label Jun 6, 2020
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Jun 6, 2020
@NetSysFire NetSysFire added the Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Help Wanted Not particularly urgent or easy (see Good First Issue for this), but help is appreciated with this! NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

No branches or pull requests

4 participants