Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unloading or Reloading items like (misc repair kit, gas mask, or sewing kit) result in none items and nothing being reloaded Respectively #40315

Closed
DramaticHotDog opened this issue May 7, 2020 · 3 comments · Fixed by #40399
Labels
(S3 - Duplicate) Bug that is duplicate of another one

Comments

@DramaticHotDog
Copy link

DramaticHotDog commented May 7, 2020

Describe the bug, Steps To Reproduce, and Screenshots

When you unload an item like (misc repair kit, gas mask, or sewing kit) it will result in an error message.

DEBUG : cannot determine reload cost as none is neither ammo or magazine

FUNCTION : int player::item_reload_cost(const item&, const item&, int) const
FILE : src/player.cpp
LINE : 2860

and a none item instead of duct tape, gas mask cartridges, and thread Respectively
EXAMPLE when unloading:
spawn in a gas mask using the Debug menu
Gas 1
take the action "Unload"
Gas 2
open inventory and verify that the none item is there
gas 3

When you reload an item like (misc repair kit, gas mask, or sewing kit) it will simply say that it was reloaded and do nothing.
EXAMPLE when reloading:
spawn in a misc repair kit and duct tape using the Debug menu
Tape 1
take the action Reload
Tape 2
Tape 3
open inventory and verify that the misc repair kit is still empty
Tape 4

Expected behavior

When unloading
When I unload a gas mask I expected to get the appropriate gas mask cartridges from it.
I expected this behavior because that is how it worked before and how I think it should function.
When reloading
When I reload a misc repair kit I expected to fill it with the appropriate item(duct tape).
I expected this behavior because that is how it worked before and how I think it should function.

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 1809
  • Game Version: 0.E-1864-gb8fb092 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Cataclysm++ [Cata++]
    ]
    using Windows 10

Additional context

  1. I loaded a new save, new world, and a new character for my test.
  2. Both of the EXAMPLES have been repeated with the following items:
  • misc repair kit
  • gas mask
  • filter mask
  • firefighter PBA mask
  • survivor fire mask
  • winter survivor mask
  • survivor divemask (tho not unloaded sins it spawns in empty)
  • sewing kit
  • tailor's kit
  1. this bug has also been repeated with a soda can stove kit where unloading it results in a none and same ERROR. Tho I have not tried to reload it sens I do not know how to spawn in concentrated alcohol in a container.

this is my first time making a Bug report so pleas give me feedback on how I did (aka tell me what I did wrong)

@ZhilkinSerg
Copy link
Contributor

Duplicate of #40158

@ZhilkinSerg ZhilkinSerg marked this as a duplicate of #40158 May 7, 2020
@ZhilkinSerg
Copy link
Contributor

Everything is fine. We already have an issue open about that. However additional info you have provided will help in investigating and fixing.

@DillonSimeone
Copy link
Contributor

This bug occurred for me when unloading an anesthesia kit too. Wanted to fill a different kit with the tiny bits left in the one I unloaded. All charges disappeared, and a none appeared in my inventory instead. (On most current build right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S3 - Duplicate) Bug that is duplicate of another one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants