Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bombastic Perks] Gaining any perk segfaults the game #71944

Closed
b3brodie opened this issue Feb 24, 2024 · 8 comments · Fixed by #71995
Closed

[Bombastic Perks] Gaining any perk segfaults the game #71944

b3brodie opened this issue Feb 24, 2024 · 8 comments · Fixed by #71995
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@b3brodie
Copy link
Contributor

Describe the bug

When selecting a perk with the perk menu, getting the perk segfaults the game.

Attach save file

Test.zip

Steps to reproduce

  1. Get enough XP to gain a perk
  2. Choose and get the perk
  3. Segfault immediately

Expected behavior

No segfault

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.4046 (22H2)
  • Game Version: d6c98a1 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    Bombastic Perks [bombastic_perks]
    ]

Additional context

No response

@b3brodie b3brodie added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Feb 24, 2024
@SariusSkelrets
Copy link
Contributor

SariusSkelrets commented Feb 24, 2024

Can confirm. Used yesterday's experimental, gained the jumpy trait
The game then crashed

Edit: removed u_mutate_towards in the perkmenu and put u_add_trait instead. No crash after that

@Standing-Storm
Copy link
Contributor

Do either of your characters have a threshold mutation? Trying to figure out why it works perfectly for me

@b3brodie
Copy link
Contributor Author

No, the characters have no thresholds. I have my test character here even without any mutations at all (other than perk menu) and they still crash.
about to crash mutationless

@b3brodie
Copy link
Contributor Author

b3brodie commented Feb 25, 2024

If it helps, this is the crash log:
crash.log

This is just a guess, but I recall some pr's that dealt with translations causing crashes with mutations, and the crash log contains a call to the translation file. This may have something to do with it? For reference my game is in English and my computer uses English as well.

@AnotherSeawhite
Copy link
Contributor

AnotherSeawhite commented Feb 25, 2024

Can confirm it crashes, regardless of mutations.

#17: 0x72a258ca04 Character::activate_mutation(string_id<mutation_branch> const&) #18: 0x72a25c4420 avatar::power_mutations() #19: 0x72a1ebd5ec game::do_regular_action(action_id&, avatar&, std::__ndk1::optional<tripoint> const&) #20: 0x72a1ecbde4 game::handle_action() #21: 0x72a1ce1bc0 do_turn() #22: 0x72a222684c SDL_main

@Standing-Storm
Copy link
Contributor

No, the characters have no thresholds. I have my test character here even without any mutations at all (other than perk menu) and they still crash. about to crash mutationless

Now I’m even more confused. You can see in the screenshot of the testing on #71898, I got a bunch of perks on that test character and never had a problem. I even tested it yesterday afternoon after I saw someone on Discord mention having a problem and it still worked.

My system and game are also in English.

@Standing-Storm
Copy link
Contributor

Standing-Storm commented Feb 26, 2024

Just got home, updated Cataclysm to get a fresh game, loaded up Bombastic Perks:

image
image

No problems, works perfectly.

@Standing-Storm
Copy link
Contributor

Okay, so because it works for me I can't test it to fix it, but can someone please try this and see if the changes I made to perkmenu,json in the following branch fixes the problem: https://github.com/Standing-Storm/Cataclysm-DDA/tree/perk-fixes/data/mods/BombasticPerks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants