[Bombastic Perks] Fix perk-choosing crash(?) #71995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Bugfix>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @bombasticSlacks
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "[Bombastic Perks] Fix perk-choosing crash(?)"
Purpose of change
Failing to explicitly list
"category"and"use_vitamins"was causing crashes for some people when selecting a perk. But not me. Everything worked perfectly for me, so there's something else going wrong withu_mutate_towardsthat this PR does not fix.I am told it fixes #71944
Describe the solution
Add
"category": "ANY", "use_vitamins": falseto the perk-gaining EoCsDescribe alternatives you've considered
Testing
I had no crashes afterwards and could properly select perks, but I also had no crashes before and could properly select perks. Someone on the Discord tested the fix and told me it works.
Additional context
I still do not know why I had no crashes at all. The documentation states that
categoryanduse_vitaminsare optional but that appears to not be the case...except for my machine. Except now that I think about it, I think I did have the same problem in #71724 until I explicitly listed"category": "MAANTOUCHED"there.