Gasoline lanterns #1117
Gasoline lanterns #1117
Conversation
|
Looks like there's no legitimate in-game way to acquire these. They should be added to the spawn lists (mapitemsdef.cpp), or at least made craftable. |
|
I knew I was missing something. I have added them to spawns that seemed feasible. Thanks! I'll probably create a recipe for them in the near future ( Survival + Mechanics? ) |
|
Alright, thanks :). And... ah, right, should've spotted this sooner: they don't actually work. The LIGHT_N flags are all special-cased, and LIGHT_3 doesn't exist yet, so it's not handled by the lightmap. On top of that, player::active_light doesn't even use those flags; it's special-cased based on the item IDs. This is really an awkward system. |
|
Ah serves me right for coding by template ;) I Intended to make it a LIGHT_4 like a candle, but put in a 3 by accident. I'll figure it out in the next days and fix it. |
|
Cool, thanks :). |
…player::active_light to indentation required by CODE_STYLE
|
Man these are weak - worse than what Night Vision gives you. But, the lighting system in general is wonky, so I'd be fine with addressing that as a separate issue. |
|
Well yes, I thought of it more as a tool to read/sew in the dark, not as something you would take to go adventuring. |
|
Yea, I've used hurricane lanterns, you can barely read by them, and they
|
|
Ah, cool, so they're supposed to be like that. |
This implements #76
I couldn't bring myself to call them hurricane lanterns though: those are normally kerosene powered and are quite dangerous when filled with gasoline.