Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove include of "bionics.h" from "character.h". #22528

Merged
merged 2 commits into from
Dec 2, 2017
Merged

Remove include of "bionics.h" from "character.h". #22528

merged 2 commits into from
Dec 2, 2017

Commits on Dec 1, 2017

  1. Remove include of "bionics.h" from cpp files that don't actually need… 

    … it.

They usually only work the bionic id (a `string_id`), and that does not need a definition from "bionics.h".
    @BevapDin
    BevapDin committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    5b6de5b View commit details
    Browse the repository at this point in the history

  2. Remove include of "bionics.h" from "character.h". 

    Changes `Character::my_bionics` to be a `copyable_uniqe_ptr<bionic_collection>`.

`bionic_collection` is a simple wrapper for `std::vector<bionic>`, defined in "bionics.h".
It can be forward declared, without defining the `bionic` class, `std::vector<bionic>` can't be forward declared without defining the `bionic` class.

Moves the definition of the destructor of `Character` into the cpp file because it implicitly requires the destructor of `bionics_collection` to be visible.
    @BevapDin
    BevapDin committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    50c345b View commit details
    Browse the repository at this point in the history