basecamp: fix cook expansion companion retrieval #27761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_faction_exp_kitchen_cooking !=_faction_exp_kitchen_crafting.
mlangsdorf
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "basecamp: fix cook expansion companion retrieval"Purpose of change
@pasko reported that he couldn't retrieve companions sent on kitchen crafting missions. Inspecting the code revealed the string used to retrieve them was different than the string used to send them out.
Describe the solution
_faction_exp_kitchen_cooking_ !=_faction_exp_kitchen_crafting_. Use_faction_exp_kitchen_cooking_in all instances.Describe alternatives you've considered
Need to replace these random strings with some string_ids at some point.