Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spear strap is now truly leather #27764

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Spear strap is now truly leather #27764

merged 1 commit into from
Jan 22, 2019

Conversation

Night-Pryanik
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Made spear strap craftable only from leather"

Purpose of change

Fixes #27759.

Describe the solution

As spear strap material is leather, removed rags from the recipe, so now it is crafted only from leather components. Also updated description to mention that it is a leather strap, not cloth one.

@Night-Pryanik Night-Pryanik added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 22, 2019
@Barhandar
Copy link
Contributor

This is a bad solution, it makes zero sense to limit straps to leather, so I think material should be removed instead, if possible.

Are there any other items that can be built out of rags OR leather, and can then be cut up into the wrong one?

@Night-Pryanik
Copy link
Contributor Author

I think material should be removed instead, if possible.

Not possible. Currently we have no mechanism of inheritance of materials based on what components were used for crafting. To mitigate such situations we may add another recipe - in this case, one recipe from the leather, and another one from rags. Unfortunately we also need to add another item - spear strap with material: cotton.

Leather is ubiquitous, I see no problems gathering it. I think this is acceptable solution.

@ZhilkinSerg ZhilkinSerg merged commit 1bb3b27 into CleverRaven:master Jan 22, 2019
@ZhilkinSerg
Copy link
Contributor

This is a bad solution, it makes zero sense to limit straps to leather, so I think material should be removed instead, if possible.

This PR is not about limiting straps to leather - it just brings strap description, recipe components and material to same value. We would be glad if someone would add another cotton strap/recipe in a different PR.

@Night-Pryanik Night-Pryanik deleted the spear-strap-recipe-and-materials-fix branch January 22, 2019 09:07
@AskaHope
Copy link

Can really a cotton strap hold a sword as effectively as a leather one?

@ZhilkinSerg
Copy link
Contributor

Can really a cotton strap hold a sword as effectively as a leather one?

Sword? This is about spear straps.

@Barhandar
Copy link
Contributor

It's not a holster, it's just a belt or a piece of rope that attaches to the spear. Pretty sure the only reason this is a holster-type item as opposed to a mod is because only ranged weapons can get mods - practically and functionally it's the exact same thing as the shoulder strap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spear strap alchemy, converts rags to leather patches.
4 participants