-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix morale decay check frequency #27803
Conversation
you forgot the last quote at the end of your summary line |
Thx |
jenkins rebuild |
We'll need to slap a profiler on this to find out if it causes lag, the
reason this kind of rate limiter is present is to avoid doing excessive
work every turn.
|
If the rate limiter is intentional (by the way, reddit is reporting slowdown on recent builds without this PR), then it should decay morale by ten times as much; alternately, all morale durations need to be 1/10th the current values. |
Isn't |
Yep - reverted frequency to 1 per minute, but made update_morale process 10 turns worth every time. Avoid potential performance problems |
Changed renderer in graphic settings to anything else than |
Summary
SUMMARY: Bugfixes "Fixes #27733 - Morale effects last 10x longer than they should
"Purpose of change
Fixes #27733
Describe the solution
Morale effect update check was running every minute ( 60 seconds ) , instead of every turn ( 6 seconds)
Now killing innocent decays over 2 days, as the effect says it should.
As to whether killing an innocent should decay over 2 days is really another issue! but this brings it in line with stated values.
Describe alternatives you've considered
N/A
Additional context
N/A