Fix at-night lighting by player #27814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Player- (and npc-) held items were performing their lighting updates before natural light falling upon walls. Furthermore, the natural light on exterior wall tiles was setting the natural light value without regard to the previous value. Consequently, at night player-held items appeared unable to illuminate exterior walls. Fix this by correcting the natural light code.
Regression test for just-fixed lighting bug.
jbytheway
force-pushed
the
night_light_sources
branch
from
0a5a6ea to
be8f6ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix lighting of exterior walls by player-held light sources at night"
Purpose of change
Player- (and NPC-) held items were performing their lighting updates before natural light falling upon walls. Furthermore, the natural light on exterior wall tiles was setting the natural light value without regard to the previous value.
Consequently, at night player-held items appeared unable to illuminate exterior walls.
Describe the solution
Fix this by correcting the natural light code.
Add a regression test.
Before:
After: