Fix inbounds override #27853
Merged
Fix inbounds override #27853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
added
<Crash / Freeze>
ZhilkinSerg
added
the
Code: Tests
kevingranade
force-pushed
the
fix-inbounds-override
branch
from
93d3f86 to
7ea5c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Fixes #27850
The new inbounds() method on tinymap wasn't being called, so it was allowing out-of-bounds accesses, some of which caused crashes.
Describe the solution
Added the virtual keyword to map::inbounds() to that tinymap could override it properly.