Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Medieval Stuff martial style traits #27906

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Jan 26, 2019

Summary

SUMMARY: Mods "Fix Medieval Stuff martial style traits."

Purpose of change

Fixes #27899.
Fixes #27831.

Describe the solution

Martial arts traits defined in the Medieval Stuff mod were overriding the base traits instead of adding to them.

Quoting @chaosvolt on why this happened.

For the longest time it would automatically append the added martial art to the list of styles. Back when I first added it I tried a full override and it populated the martial arts list with duplicate entries for the styles that were on the list in vanilla, but it worked when I used the method you've seen here. Seems that behavior's changed at some point.

@KITbutler
Copy link

Is there no "append" syntax to allow multiple martial arts mods?

@JoaoMagal
Copy link

@ifreund Could you also change the Melee Weapon Training trait to add Niten Ichi-Ryu and Sojutsu in the description? That one little thing is bothering me since Niten was added to the trait lol

@ifreund
Copy link
Contributor Author

ifreund commented Jan 26, 2019

@ifreund Could you also change the Melee Weapon Training trait to add Niten Ichi-Ryu and Sojutsu in the description? That one little thing is bothering me since Niten was added to the trait lol

On it, must have read too fast when I was reading through your issue.

@ifreund ifreund force-pushed the fix-medieval-style-traits branch from 3247002 to 9dbc892 Compare January 26, 2019 19:19
@ZhilkinSerg ZhilkinSerg added Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Bugfix> This is a fix for a bug (or closes open issue) labels Jan 27, 2019
@ZhilkinSerg ZhilkinSerg merged commit 9e8d055 into CleverRaven:master Jan 28, 2019
@ifreund ifreund deleted the fix-medieval-style-traits branch February 5, 2019 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants