Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pry 1 to toolbox #27914

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Jan 27, 2019

Summary

SUMMARY: Bugfixes "Add pry 1 to toolbox."

Purpose of change

The toolbox includes a hammer which has pry one, but the toolbox currently lacks this quality.

@Rivet-the-Zombie Rivet-the-Zombie merged commit a9341fb into CleverRaven:master Jan 27, 2019
@jbytheway
Copy link
Contributor

Fixes like this seem to keep happening. It would be great if someone could add unit tests to ensure that the toolbox (and similar items like the survivor utility belt) have qualities matching their ingredients.

@FulcrumA
Copy link
Contributor

I am not sure if it'd work, given many recipes result in items which logically do not maintain all qualities of their separate ingredients, unless it'd be a test only testing certain items added to the list manually - at which point we can as well check them on our own.

@ifreund ifreund deleted the toolbox-add-pry branch February 5, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants