Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement of surgery UI #31498

Merged
merged 23 commits into from
Jun 19, 2019
Merged

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Jun 16, 2019

Summary

SUMMARY: Interface "Small improvement of surgery UI"

Purpose of change

Improves UI of installing/uninstalling CBMs.
fixes #28714

Describe the solution

  • Can't select CBM in menu if you don't have enough anesthetic

  • Put messages in the right order

  • Bring the install menu to cbm uninstall

  • ScreenShots:

    • Install with some anesthetic:
      image
    • Uninstall with some anesthetic:
      image
      (I don't know why the CBMs display in grey)
      -Install/Uninstall with no anesthetic:
      image
      -Install/Uninstall with anesthetic kit:
      image

Describe alternatives you've considered

Additional context

In order to display the menu for uninstallation the game adds CBMs corresponding to your bionics to your inventory and remove them after you've made your choice.

This also make Bionic require a CBM item to be defined (unless they are included) otherwise the game will throw an error at load and Bionic without corresponding CBM Item will unremovable.

@Night-Pryanik
Copy link
Contributor

While you're here, could you please place a period at the end of the You set up the operation step-by-step, configuring the Autodoc to manipulate a CBM string in introduce_into_anesthesia function?

@ifreund ifreund added <Enhancement / Feature> New features, or enhancements on existing [C++] Changes (can be) made in C++. Previously named `Code` Bionics CBM (Compact Bionic Modules) Info / User Interface Game - player communication, menus, etc. labels Jun 16, 2019
@Fris0uman Fris0uman marked this pull request as ready for review June 16, 2019 20:53
@Fris0uman
Copy link
Contributor Author

@KorGgenT Should has_enough_anest() go in avatar.cpp instead of player.cpp ?

@KorGgenT
Copy link
Member

do you expect an NPC to ever use this function? if so, put it in Character.
otherwise, put it in avatar. this goes for all new functions as well. If you don't know, i'll do a more thorough review later.

@ZhilkinSerg ZhilkinSerg self-assigned this Jun 17, 2019
@Fris0uman
Copy link
Contributor Author

Turns out that since it uses crafting_inventory()moving it to Character is not trivial. It should be ok to leave it as is since the definition is in player.h but the function is actually in bionic.cpp

@KorGgenT
Copy link
Member

i see. i suppose that's one more thing to add to the "deprecate player class project"

@ZhilkinSerg ZhilkinSerg merged commit f6326fd into CleverRaven:master Jun 19, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jun 19, 2019
@Fris0uman Fris0uman deleted the UI_surgery branch June 21, 2019 12:45
@Fris0uman Fris0uman mentioned this pull request Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bionic installation shows success/faulure messages before the operation
5 participants