Fix keg iexamine with bathtubs #31652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bathtubs don't have the NOITEM flag that iexamine::keg expects, which causes unexepected things to happen. This commit introduces a fake `f_no_item` furniture to use in a hack to handle item displacement from the keg tile correctly.
ifreund
added
[C++]
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix keg iexamine with bathtubs."
Purpose of change
Fixes #31541
Bathtubs don't have the NOITEM flag that iexamine::keg expects, which
causes unexepected things to happen.
Describe the solution
This commit introduces a fake
f_no_itemfurniture to use in a hackto handle item displacement from the keg tile correctly.
Additional context
It seems the crash on examining while empty of liquid may have been fixed by #31406 already, but there were still issues if there was liquid preset.