Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bathroom scale #31849

Merged
merged 4 commits into from
Jun 27, 2019
Merged

add bathroom scale #31849

merged 4 commits into from
Jun 27, 2019

Conversation

KorGgenT
Copy link
Member

@KorGgenT KorGgenT commented Jun 25, 2019

Summary

SUMMARY: Features "Add bathroom scale iuse"

Purpose of change

I wanted a more accessible way for the player to see their weight.

Describe the solution

Created a new iuse_actor called weigh_self_actor
created a basic bathroom scale item.
max_weight is in grams. shows "ERROR" if you are too heavy.
Note: I did not add this to itemgroups, if someone else would be so kind to do that it would be much appreciated.

image

Shows kgs or lbs depending on what setting you have.

@KorGgenT KorGgenT added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` labels Jun 25, 2019
@NickGrease
Copy link
Contributor

With analog scales you'd know you were at least xxx kg/lb's (the dial would stop at what ever the max weight it could handle). Never used a digital one - but I think it would be fair to include the max weight in the error message, "ERROR Max Weight (xxx) Exceeded" or some such. Just so the person has at least some idea of their weight.

src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
src/iuse_actor.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit 9db82e4 into CleverRaven:master Jun 27, 2019
@KorGgenT KorGgenT deleted the bathroom-scale branch August 13, 2020 04:17
@int-ua
Copy link
Contributor

int-ua commented Dec 10, 2020

FYI: ASCII fallback for ■ symbol doesn't work with current tilesets, it's becoming unknown tile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants