Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add washcloth #34124

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Add washcloth #34124

merged 3 commits into from
Sep 20, 2019

Conversation

harakka
Copy link
Member

@harakka harakka commented Sep 20, 2019

Summary

SUMMARY: Content "Add washcloth, craftable alternative to sponge"

Purpose of change

Currently the sponge and wash kit are the only tools that can be used to wash hard items. Washcloth does the same job and is trivially craftable, as in, you just take a rag and designate it as a washcloth by using the crafting recipe.

Describe the solution

A rag can be converted to a washcloth via autolearned recipe that has no skill requirements. Washcloth can also be deconstructed back to rag, since the crafting action is just meant to indicate that you will now use this rag for the purpose of washing items.

Describe alternatives you've considered

Adding an use action to the rag might be more convenient once the player knows the option exist, but I recall seeing it mentioned that sponge exists in part because the action is already taken.

Washcloth does the same job as a sponge, but can be crafted from a rag.
@Fris0uman
Copy link
Contributor

Fris0uman commented Sep 20, 2019

Add it to the wash kit recipe?
Also you need to lint your changes

@harakka
Copy link
Member Author

harakka commented Sep 20, 2019

@Fris0uman my bad, I was hoping I could just sneak in a quick small commit from Github's web UI, but of course such hubris could not be. Didn't have a dev environment set up and hadn't looked into a makefile in maybe 10 years but got the linter working now.

Does the wash kit recipe change look ok?

@anothersimulacrum
Copy link
Member

Looks good to me

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Sep 20, 2019
@ZhilkinSerg ZhilkinSerg merged commit 7d6e0d4 into CleverRaven:master Sep 20, 2019
@reed501
Copy link
Contributor

reed501 commented Sep 20, 2019

From a balance perspective what's the point of a sponge now? Should there be some enhanced use of a sponge at some point or is sponge just a worse version of something else now?

@ZhilkinSerg
Copy link
Contributor

Consider sponge one of SUS items.

misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
* Add washcloth

Washcloth does the same job as a sponge, but can be crafted from a rag.

* Add sponge as option to wash kit recipe
@blot-runner
Copy link
Contributor

Consider sponge one of SUS items.

Er, what is SUS in this context?

@ZhilkinSerg
Copy link
Contributor

#29706

@blot-runner
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants