-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basements update #34657
Basements update #34657
Conversation
"place_monsters": [ { "monster": "GROUP_ZOMBIE", "x": [ 9, 16 ], "y": [ 12, 16 ] } ] | ||
} | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
] | |
] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're serious about working on the basements you might want to look into Specific Use Storage #29706 and nested chunks.
{ "item": "electronics", "chance": 30 }, | ||
{ "item": "supplies_electronics", "chance": 30 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you think about alternatives for these? I can't really explain why they would show up in the chem lab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a pure chem lab (there's a meth basement for this), it's more like a "generic home laboratory".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay I can see where you're coming from.
Yeah, I plan to do things with nested chunks (I thought about another place for them but basements would be okay too), and thanks for the link! |
really great, I like the varied sizes too. |
Hmmm, I wonder why Travis is complaining. |
It's complaining on every PR last days, don't pay attention to it. |
Summary
SUMMARY: Content "Updates house basements'"
Purpose of change
Weed basement and chem basement are in fact huge cold empty rooms. Time to give them some love.
Describe the solution
I changed them to more interesting (I believe) layout. Chem basement now has two variations - "home workshop" and a slightly more rare "home laboratory". I included another basement type - a tight messed room filled with random old junk. Also I adjusted weights, so there will be more variety underground (I barely saw residential basements before this).
Describe alternatives you've considered
Leave everything as is.
Update everything in one go.
Leave old empty rooms along with the new ones.
Testing
Created a half-dozen of new worlds, jumped around, checked out new basements and ensured they work as designed. Everything looks fine.
Additional context
I plan to maybe remove hardcoded basements (basement_junk, namely) and replace them with jsonized ones (jsonizing spider basements, of course). Also I plan to update other basements, add more variety to them, add special rare rooms and make more varieties of the messed basement.
Chem (lab)
Chem (workshop)
Messed
Weed