Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basements update #34657

Merged
merged 5 commits into from
Oct 18, 2019
Merged

Conversation

chaisawlajatang
Copy link
Contributor

Summary

SUMMARY: Content "Updates house basements'"

Purpose of change

Weed basement and chem basement are in fact huge cold empty rooms. Time to give them some love.

Describe the solution

I changed them to more interesting (I believe) layout. Chem basement now has two variations - "home workshop" and a slightly more rare "home laboratory". I included another basement type - a tight messed room filled with random old junk. Also I adjusted weights, so there will be more variety underground (I barely saw residential basements before this).

Describe alternatives you've considered

Leave everything as is.
Update everything in one go.
Leave old empty rooms along with the new ones.

Testing

Created a half-dozen of new worlds, jumped around, checked out new basements and ensured they work as designed. Everything looks fine.

Additional context

I plan to maybe remove hardcoded basements (basement_junk, namely) and replace them with jsonized ones (jsonizing spider basements, of course). Also I plan to update other basements, add more variety to them, add special rare rooms and make more varieties of the messed basement.

Chem (lab)
chem
Chem (workshop)
chem1
Messed
mess
Weed
weed

"place_monsters": [ { "monster": "GROUP_ZOMBIE", "x": [ 9, 16 ], "y": [ 12, 16 ] } ]
}
}
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
]
]

Copy link
Contributor

@snipercup snipercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're serious about working on the basements you might want to look into Specific Use Storage #29706 and nested chunks.

Comment on lines +76 to +77
{ "item": "electronics", "chance": 30 },
{ "item": "supplies_electronics", "chance": 30 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you think about alternatives for these? I can't really explain why they would show up in the chem lab?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a pure chem lab (there's a meth basement for this), it's more like a "generic home laboratory".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay I can see where you're coming from.

@chaisawlajatang
Copy link
Contributor Author

If you're serious about working on the basements you might want to look into Specific Use Storage #29706 and nested chunks.

Yeah, I plan to do things with nested chunks (I thought about another place for them but basements would be okay too), and thanks for the link!

@curstwist
Copy link
Contributor

really great, I like the varied sizes too.

@ZhilkinSerg ZhilkinSerg added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Oct 13, 2019
@chaisawlajatang
Copy link
Contributor Author

Hmmm, I wonder why Travis is complaining.

@Night-Pryanik
Copy link
Contributor

It's complaining on every PR last days, don't pay attention to it.

@ZhilkinSerg
Copy link
Contributor

Hmmm, I wonder why Travis is complaining.

There is Clang check failing (will be addressed in #34823) and Android build timeout (was addressed in #34806).

@kevingranade kevingranade merged commit 7e52b20 into CleverRaven:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants