Smelling Sweet

[Fris0uman]

Summary

SUMMARY: Features "Scents can have a type"

Purpose of change

Instead of every player smelling the same, now mutation can give a specific type of smell and monsters can track a specific smell.

• scent_type can be defined in json and list the species able to smell them

• Chloromorph mutation now gives the sc_flower scent that can be perceived by mammals, insects, mollusk and birds.

• The scent effect of Weak Scent, Strong Scent and Smelly are now defined in json with scent_intensityentry

• The scent effect of Flowers is now defined in json using scent_mask

• In My Sweet Cataclysm the Made Of Sugar mutation gives the sc_sugar scent instead of suppressing scent. It can be tracked by mammals, insects and fungi.

Describe the solution

• Add typescent to the scent_map that describe the type of the smell
  A player can still only produce one scent
• Add debug option to display that map
• Use generic factory to add the scent_type class
• Add new entries to mutations for the jsonisation
• Add tracked_scent to monster to definde tracked scent per monster on top of the species definition in scent_type.json

Describe alternatives you've considered

Testing

Star a new My Sweet Cataclysm world
Turn on debug scent map
See sc_sugar scent
Make sure that zombie are still not following the scent
Debug Chloromorph scent
Still smell of sc_sugar: mutation that affect scent should be made exclusive
Debug remove Sugar mutation
Smell of sc_flower
Debug invisibility
Zombies are not tracking the scent
Save,Quit,Re-load
The scent map is still the same.

Additional context

[dunstad]

I was just about to comment on the scent issues with the ignored_by flag, this should help! Good stuff.

[kevingranade]

I said something about this, probably on Discord, but I think I was unclear.
You're tracking scent type in a parallel array of values, but AFAICT all you NEED to do is stash "what does the player smell like" in a single value, and update it when the player code writes it's current scent to the map.
Changes in scent type happen so rarely that there's no reason to track the scent type for each square of scent map.
All your interfaces to scent_map will remain unchanged, but just replace the typescent array with a single typescent value and update the various pieces of code in scent_map to do the right thing.

[ZhilkinSerg]

You should probably add an empty keybinding to data/raw/keybinding.json:

  {
    "type": "keybinding",
    "name": "View Scent Type",
    "category": "DEFAULTMODE",
    "id": "debug_scent_type"
  },

[ZhilkinSerg]

Can you resolved conflicts please?