-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed weights for all real firearms. #34908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warriorcat49
changed the title
WIP Fixed weights for all real firearms.
Fixed weights for all real firearms.
Oct 21, 2019
ZhilkinSerg
added
Game: Balance
Balancing of (existing) in-game features.
Items / Item Actions / Item Qualities
Items and how they work and interact
Ranged
Ranged (firearms, bows, crossbows, throwing), balance, tactics
labels
Oct 21, 2019
ZhilkinSerg
reviewed
Nov 18, 2019
Co-Authored-By: ZhilkinSerg <ZhilkinSerg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Game: Balance
Balancing of (existing) in-game features.
Items / Item Actions / Item Qualities
Items and how they work and interact
Ranged
Ranged (firearms, bows, crossbows, throwing), balance, tactics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue #34830.
Summary
SUMMARY: Balance "Fixed weights for all real firearms."
Purpose of change
Fixes #34830 - 3/4ths of all real guns are heavily underweight.
Describe the solution
Accurate weights have been applied to all real firearms, with exception to Savage 111F and Taurus Pro .38 (These firearms do not exist as currently modeled and cannot have accurate weights ascribed to them until otherwise changed). Firearms within 1% of real weight have been left because they're probably accurate enough as they are.
Additional context
Google Sheets spreadsheet with all real firearms and their current modeled weights/real-world weights.
https://docs.google.com/spreadsheets/d/1amMgy_2Yq13aScDdUp7b8HSUS6mZLT9Ddjxoc9k3ruI/edit?usp=sharing