NPCs - added a new hunter NPC that trades with the player to two locations #35121

Brytenwalda · 2019-10-28T21:50:20Z

Summary

SUMMARY: Content "A new type of a hunter NPC will spawn in some cabins and campsites"

Purpose of change

More NPC hunters would make the world more plausible - hunting and fishing are some of the easiest ways to obtain food after the apocalypse, and one of the few long-term solutions left. As cabins are one of the best places to live in, it shouldn't be surprising to find survivors there.

It also goes along with my Free Merchants additions - hunters sell their surplus to Free Merchants, who in turn sell it to survivors who don't produce enough for themselves or their families.

Describe the solution

I created a new hunter NPC who trades in food, water and furs. He has multiple dynamic speech options so it doesn't feel like you're always talking to the same person.
NPCs will spawn in some cabins and campsites (I added two special types of these).

Describe alternatives you've considered

It would be great if, at some point in the future, they would wander around the area as well, but I have no idea how to code it.

Testing

I tested everything and it should work properly.

EDIT: It seems that some checks failed due to reasons completely unrelated to any of my changes.

ghost · 2019-10-29T10:20:19Z

It would be better to make a new faction for this hunter,
"wasteland_scavengers" is a legacy faction thing, where previously all dynamic NPCs and some static ones belonged to it, if you add your hunter to this faction, and someone kills this hunter, then some members of the refugee center will telepathically know and go hostile to the player.

Or use the existing no_faction faction, which has different rules in the code, ( i.e it dosnt telepathically communicate wrongdoing across its "members" )

Brytenwalda · 2019-10-29T10:41:49Z

It would be better to make a new faction for this hunter,
"wasteland_scavengers" is a legacy faction thing, where previously all dynamic NPCs and some static ones belonged to it, if you add your hunter to this faction, and someone kills this hunter, then some members of the refugee center will telepathically know and go hostile to the player.

Or use the existing no_faction faction, which has different rules in the code, ( i.e it dosnt telepathically communicate wrongdoing across its "members" )

Changed it, they now have a faction of their own. Until we have dynamic factions for individuals, this is necessary for the item ownership.

Night-Pryanik · 2019-11-02T04:55:31Z

data/json/mapgen/campsite.json

+      },
+      "place_items": [
+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 21, 7 ], "chance": 75 },
+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 21, 7 ], "chance": 75 },


This is a duplicate of a line above. Is it an error, or you just wanted to make cannedfood itemgroup have double rolls to spawn?

Also, "y": [ 21, 7 ] (and the like down below) is a weird notation. Did you mean "y": [ 7, 21 ]?

I wanted it to have double rolls for greater variety.

The notation is of course a mistake, corrected.

Night-Pryanik · 2019-11-02T05:00:29Z

data/json/npcs/NC_HUNTER.json

+      [ "bolt_wood", 90 ],
+      [ "bolt_wood", 90 ],


You should use syntax like { "item": "bolt_wood", "prob": 90, "count": 2 }. Here and below.

data/json/npcs/NC_HUNTER.json

Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>

Night-Pryanik · 2019-11-04T09:17:44Z

data/json/mapgen/campsite.json

+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },


Double rolls can be achieved by { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75, "repeat": 2 }

Night-Pryanik · 2019-11-04T09:18:10Z

data/json/mapgen/campsite.json

+        "r": "f_tourist_table"
+      },
+      "place_items": [
+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },


Suggested change

{ "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },

{ "item": "cannedfood", "x": [ 4, 16 ], "y": [ 7, 21 ], "chance": 75 },

Night-Pryanik · 2019-11-04T09:18:29Z

data/json/mapgen/campsite.json

+      "place_items": [
+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
+        { "item": "pasta", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },


Suggested change

{ "item": "pasta", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },

{ "item": "pasta", "x": [ 4, 16 ], "y": [ 7, 21 ], "chance": 75 },

Night-Pryanik · 2019-11-04T09:18:41Z

data/json/mapgen/campsite.json

+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
+        { "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
+        { "item": "pasta", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
+        { "item": "camping", "x": [ 10, 8 ], "y": [ 15, 13 ], "chance": 75 }


Suggested change

{ "item": "camping", "x": [ 10, 8 ], "y": [ 15, 13 ], "chance": 75 }

{ "item": "camping", "x": [ 8, 10 ], "y": [ 13, 15 ], "chance": 75 }

stale · 2019-12-04T09:19:54Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

I-am-Erk · 2019-12-16T22:41:03Z

@Brytenwalda I'd love to merge this and your other changes, they just need a few fixes and some conflict resolution. Feel free to reopen these if you come back to fix up the last bits. I can talk to you on discord to help fix the last bits if you need help.

Brytenwalda added 5 commits October 28, 2019 21:42

Hunters

c342caa

Update cabin.json

7a6f38f

Update NC_HUNTER.json

39eb185

Update campsite.json

21a3567

Update NC_HUNTER.json

78cb7d4

Brytenwalda changed the title ~~NPCs - added a new hunter NPC that trades with the player to two locations~~ NPCs - added a new hunter NPC that trades with the player in two locations Oct 28, 2019

Brytenwalda changed the title ~~NPCs - added a new hunter NPC that trades with the player in two locations~~ NPCs - added a new hunter NPC that trades with the player to two locations Oct 28, 2019

Update cabin.json

697e206

ghost mentioned this pull request Oct 29, 2019

A psychotic NPC - The Sheep Counter #35071

Closed

Brytenwalda added 3 commits October 29, 2019 10:39

Faction

ee591b1

Update factions.json

3ab9b3a

Update factions.json

eadd3cb

curstwist added [JSON] Changes (can be) made in JSON NPC / Factions NPCs, AI, Speech, Factions, Ownership Map / Mapgen Overmap, Mapgen, Map extras, Map display labels Oct 29, 2019

Brytenwalda added 3 commits October 29, 2019 23:26

Update NC_HUNTER.json

0fb8a2a

Update NC_HUNTER.json

307eccc

Update NC_HUNTER.json

f7c832e

Night-Pryanik reviewed Nov 2, 2019

View reviewed changes

data/json/npcs/NC_HUNTER.json Outdated Show resolved Hide resolved

Brytenwalda and others added 5 commits November 3, 2019 23:58

Update data/json/npcs/NC_HUNTER.json

d50972d

Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>

Update campsite.json

b94b69f

Update campsite.json

331c089

Update NC_HUNTER.json

76bbbd4

Update NC_HUNTER.json

af3e980

Night-Pryanik reviewed Nov 4, 2019

View reviewed changes

stale bot added the stale Closed for lack of activity, but still valid. label Dec 4, 2019

weekly-digest bot mentioned this pull request Dec 8, 2019

Weekly Digest (1 December, 2019 - 8 December, 2019) #35955

Closed

I-am-Erk closed this Dec 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NPCs - added a new hunter NPC that trades with the player to two locations #35121

NPCs - added a new hunter NPC that trades with the player to two locations #35121

Brytenwalda commented Oct 28, 2019 •

edited

Loading

ghost commented Oct 29, 2019

Brytenwalda commented Oct 29, 2019 •

edited

Loading

Night-Pryanik Nov 2, 2019 •

edited

Loading

Brytenwalda Nov 4, 2019

Night-Pryanik Nov 2, 2019

Brytenwalda Nov 4, 2019

Night-Pryanik Nov 4, 2019

Night-Pryanik Nov 4, 2019

Night-Pryanik Nov 4, 2019

Night-Pryanik Nov 4, 2019

stale bot commented Dec 4, 2019

I-am-Erk commented Dec 16, 2019

		{ "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
		{ "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },

	{ "item": "cannedfood", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
	{ "item": "cannedfood", "x": [ 4, 16 ], "y": [ 7, 21 ], "chance": 75 },

	{ "item": "pasta", "x": [ 16, 4 ], "y": [ 7, 21 ], "chance": 75 },
	{ "item": "pasta", "x": [ 4, 16 ], "y": [ 7, 21 ], "chance": 75 },

	{ "item": "camping", "x": [ 10, 8 ], "y": [ 15, 13 ], "chance": 75 }
	{ "item": "camping", "x": [ 8, 10 ], "y": [ 13, 15 ], "chance": 75 }

NPCs - added a new hunter NPC that trades with the player to two locations #35121

NPCs - added a new hunter NPC that trades with the player to two locations #35121

Conversation

Brytenwalda commented Oct 28, 2019 • edited Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

ghost commented Oct 29, 2019

Brytenwalda commented Oct 29, 2019 • edited Loading

Night-Pryanik Nov 2, 2019 • edited Loading

Choose a reason for hiding this comment

Brytenwalda Nov 4, 2019

Choose a reason for hiding this comment

Night-Pryanik Nov 2, 2019

Choose a reason for hiding this comment

Brytenwalda Nov 4, 2019

Choose a reason for hiding this comment

Night-Pryanik Nov 4, 2019

Choose a reason for hiding this comment

Night-Pryanik Nov 4, 2019

Choose a reason for hiding this comment

Night-Pryanik Nov 4, 2019

Choose a reason for hiding this comment

Night-Pryanik Nov 4, 2019

Choose a reason for hiding this comment

stale bot commented Dec 4, 2019

I-am-Erk commented Dec 16, 2019

Brytenwalda commented Oct 28, 2019 •

edited

Loading

Brytenwalda commented Oct 29, 2019 •

edited

Loading

Night-Pryanik Nov 2, 2019 •

edited

Loading