Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell-casting NPCs #35597

Merged
merged 17 commits into from
Jan 5, 2020
Merged

Spell-casting NPCs #35597

merged 17 commits into from
Jan 5, 2020

Conversation

araneyl
Copy link
Contributor

@araneyl araneyl commented Nov 19, 2019

Adds spellcasting npcs to magiclysm

Summary

SUMMARY: Content "Adds Spell-casting NPCs"

Purpose of change

Introduces NPCs that know spells to Magiclysm. Includes npc specific factions and quests.

Describe the solution

Adds 3 new npc classes, an old Magus, a Priest that can heal, and a Technomancer 'Child'
2 new factions, an ancient group of Magus that are now out in the open and a group that want to purge the world of its curse (the cataclysm) using their new found powers
and 4 new quests specific to the new npcs, 2 'fetch' quests and 2 kill missions.

Describe alternatives you've considered

n/a

Testing

Appears to work. Loads into game, npcs talk and give quests. Quests seem to function as intended but they havnt been put through a strenuous test.

Additional context

I had hoped to put more work into this but life keeps getting in the way. Eventually I'd like to expand the dialog and quest lines as well as fill out the missions and npc stats to make them more 'thematic' to their factions. But since I don't know when I'll get the chance I'm going to see if this is enough for now and go from here when I can.

adds spellcasting npcs to magiclysm
@araneyl araneyl changed the title spellcasting npcs Spell-casting NPCs Nov 19, 2019
linted
@aoae23
Copy link
Contributor

aoae23 commented Nov 19, 2019

Blessed be.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Nov 19, 2019
@araneyl
Copy link
Contributor Author

araneyl commented Nov 25, 2019

For anyone watching this, its not abandoned; I just havn't had as much time to work on it as I had hoped. I should have more soon(tm).

should be the last peices to get them working in game
misplaced file and linted
finally, maybe.
@araneyl araneyl marked this pull request as ready for review December 11, 2019 23:16
@KorGgenT KorGgenT self-assigned this Dec 12, 2019
@KorGgenT
Copy link
Member

KorGgenT commented Dec 14, 2019

going through the healer questline:

  • i would like it to be more obvious from what he tells you when you accept the quest that you need to go kill zombies. i had to check the mission menu in order to know what i needed to do
  • after completing the second mission, and asking for another quest, i got this error message
    image

@KorGgenT
Copy link
Member

for the magus:

  • make sure to mention the name of the book you're looking for in both the quest response and the mission screen

@araneyl
Copy link
Contributor Author

araneyl commented Dec 14, 2019

on my local files i have the changes to make clearer what you need for both of the npcs. i can push those any time.

i have no idea how to change the text on the mission screen. someone is going to have to point me in a direction, i havnt seen anything about that so far.
that error makes no sense to me, theres a line to link missions sequentially that i thought i used correctly but i have no idea why it threw that error.

more descriptive information in the mission dialog
@araneyl
Copy link
Contributor Author

araneyl commented Dec 14, 2019

Last night someone was on discord and mentioned getting that nullptr error while dealing with 'Dino Dave' from the refugee center. I tried to get more from them about it but they didnt respond. I don't have the time atm to see if I can reproduce the error with DDave but I will when I get a chance. Perhaps there is something undiagnosed or a new error with mission chains? I wont make an issue till i can confirm the error on my side.

@KorGgenT
Copy link
Member

note to self: all the periods need an extra space (for when i come back to this tonight)

added spaces after periods (double space after each .)
changed ellipses to the unicode character
data/mods/Magiclysm/npc/missiondef.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/missiondef.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/missiondef.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/npc/missiondef.json Outdated Show resolved Hide resolved
araneyl and others added 3 commits December 30, 2019 23:05
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
araneyl and others added 6 commits December 30, 2019 23:05
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
fixed double space, tag in wrong file, tag incomplete
maybe this is right?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants