Adds new profession: Kitted Survivor #35650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2019 22:49
Costs 1 point. Starts with worse clothing than the ordinary Survivor but has a full survival kit which can aid them. Inspired by Cataclysm++'s "Canned Survivor", who starts with a decked out "Survival In A Can" kit.
data/json/professions.json
Outdated
| "type": "profession", | ||
| "ident": "kit_survivor", | ||
| "name": "Kitted Survivor", | ||
| "description": "At the local mall, you saw a sign advertising a discount on survival kits. You bought one, more for show than for actual use. Now, it's all you have." |
There was a problem hiding this comment.
Suggested change
| "description": "At the local mall, you saw a sign advertising a discount on survival kits. You bought one, more for show than for actual use. Now, it's all you have." | |
| "description": "At the local mall, you saw a sign advertising a discount on survival kits. You bought one, more for show than for actual use. Now, it's all you have.", |
There was a problem hiding this comment.
Oh - how do I lint my JSON?
And, if you have any other description ideas, feel free to suggest them.
There was a problem hiding this comment.
Lint the whole file contents with a http://dev.narc.ro/cataclysm/format.html
|
And fix the summary. |
Missing Comma Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
AMurkin
reviewed
Nov 22, 2019
Double spaces. Co-Authored-By: Alexey Mostovoy <1931904+AMurkin@users.noreply.github.com>
AMurkin
reviewed
Nov 22, 2019
ZhilkinSerg
added
[JSON]
Removed extra comma Co-Authored-By: Alexey Mostovoy <1931904+AMurkin@users.noreply.github.com>
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Added new Profession 'Kitted Survivor'"
Purpose of change
Describe the solution
Allows players to start with a survival kit, which might aid them.
Describe alternatives you've considered
Not adding this profession.
Testing
Additional context