-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monster flag usage frequency #35740
Monster flag usage frequency #35740
Conversation
Why even keep the bitset? Why not just the boolean members? We usually check for flags that are known at compile type. |
That is the intention - find which flags are accessed often and have replaced them with boolean members. Changing this immediately would required bigger changes both to code and json and I am trying to avoid it for now. |
ec9e4d1
to
62e4702
Compare
62e4702
to
0c188e1
Compare
Summary
SUMMARY: Infrastructure "Monster flag usage frequency"
Purpose of change
Allow gathering statistics on accessing various monster flags.
Describe the solution
Added gathering of monster flag usage statistics.
Additional context
Current PR would allow gathering monster flag usage statistics, so we could later move frequently accessed flags to monster type class fields.
Data can be dumped to
debug.log
through "Game State" debug menu. Data is sorted by usage count in descending order. Data format is the following (can be directly inserted to spreadsheet apps):I will move most offending flags into monster/mtype properties in separate pull requests like #35775.