Limit the kinds of terrain that are vulnerable to mattack::growplants

[Kodiologist]

Summary

SUMMARY: Balance "Limit the kinds of terrain that are vulnerable to mattack::growplants"

Purpose of change

The TODO comment I replaced said "Make this sensible - it can destroy EVERYTHING". Triffid queens could destroy liquids, stairs, computers, etc.

Fixes #24995.

Describe the solution

Only DIGGABLE terrain or trees can be affected by triffid queens.

Testing

I watched a triffid queen tear up the area outside a shelter without affecting the inside.

[BevapDin]

You can put this loop into a separate function and return from within the loop so you avoid using goto.

[Kodiologist]

Why?

[kevingranade]

Avoid auto, never use goto.
I recomend you build your list as a static const map, and instead of the goto shuffle, capture a boolean indicating success or failure and use it to decide to bail out.

From a game logic point of view, I suspect the only flag we actually care about here is DIGGABLE, which makes things even simpler. I like the logic of simply needing to retreat to man made structures to avoid most of the danger.

[Kodiologist]

I recomend you build your list as a static const map

Probably it's just because my C++ is rusty, but I'm not sure what that is or how I would solve the problem with it.

From a game logic point of view, I suspect the only flag we actually care about here is DIGGABLE, which makes things even simpler. I like the logic of simply needing to retreat to man made structures to avoid most of the danger.

Oh, I see. I thought it was intended that triffid queens could tear up buildings.

[I-am-Erk]

Long term, not in this pr, it would be nice to make flammable flagged terrain become overgrown with vines rather than replaced fully with trees

[Kodiologist]

This PR now takes a completely different approach, per Kevin's comment. Check it out.

[BevapDin]

I recommend checking for the "TREE" flag instead of "t_tree". There are all kinds of trees in the game, and they all have different ids.

[Kodiologist]

I know, but I didn't think we would want to allow triffid queens to destroy fruit trees, etc.; the only reason to allow tree destruction at all is to keep them from getting trapped.

[ZhilkinSerg]

Outworld triffids won't differentiate between Earth plant genera.

[Kodiologist]

Okay, done. We still need an explicit check for t_tree_young because it's not a TREE.

[Kodiologist]

Regarding the "Mutations / Traits / Professions" tag, this function should only be available to triffid queens, not player plant-type mutants (yet?).