Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical Overmap update #35792

Merged
merged 15 commits into from
Jan 4, 2020
Merged

Conversation

Larwck
Copy link
Contributor

@Larwck Larwck commented Nov 30, 2019

Summary

SUMMARY: Mods "Update to Graphical Overmap mod"

Purpose of change

I felt the readme and modinfo needed more information to clarify some things. This mod is certainly a bit of a fuss to get working. I also don't think the merge caught my last update, which fixed some bg color issues.

Describe the solution

Noted in modinfo the importance of reading the readme. Clarified how to remove 5x5 location map from the sidebar in the readme. To further simplify the install have moved the font.png to the fonts folder.

Describe alternatives you've considered

Testing

Additional context

@tinukedaya
Copy link
Contributor

Any chance you would make the map work with smaller font size than 16? I really love how your map looks, but would like it even more if I can set it a bit smaller.

@Larwck
Copy link
Contributor Author

Larwck commented Nov 30, 2019

Any chance you would make the map work with smaller font size than 16? I really love how your map looks, but would like it even more if I can set it a bit smaller.

Thanks! This would require me to create all new icons of a smaller size, which is certainly possible but not something I'm planning on doing soon. 16px is a comfort zone for me when making pixel art. If anyone wants to make their own tileset, they can use mine as a reference and as long as each relevant icon is in the same position with a bit of fiddling with the options and fonts.json we could get it working fairly quickly.

@ZhilkinSerg
Copy link
Contributor

I suggest moving font to fonts folder to simplify installation.

Any chance you would make the map work with smaller font size than 16? I really love how your map looks, but would like it even more if I can set it a bit smaller.

8x8 would look gross

image

@ZhilkinSerg ZhilkinSerg added <Documentation> Design documents, internal info, guides and help. Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding SDL: Tiles / Sound Tiles visual interface and sounds. labels Nov 30, 2019
@tinukedaya
Copy link
Contributor

8x8 would look gross

image

I was thinking more like 12x12 than 8. I can see that 8 would be loosing too much of it's details and look really bad.

@Larwck Larwck changed the title [WIP] Graphical Overmap minor update [WIP] Graphical Overmap update Dec 1, 2019
@ZhilkinSerg ZhilkinSerg mentioned this pull request Dec 9, 2019
@Kilvoctu
Copy link
Contributor

A little late to the party, but I just applied this mod to my savegame. The font (graphics) were much too small for my display, as my overmap is typically at fontsize 28. To reduce the need to squint, I modified the map_font_LARWICK.png.
Figure I provide the pngs as options for any other users. These are for 24 and 32 fontsize respectively. I tested them and they work with no graphical issues, though 24 looks slightly distorted as it's not pixel perfect (still looks fine to me in-game).

map_font_LARWICK_24.png:
map_font_LARWICK_24

map_font_LARWICK_32.png:
map_font_LARWICK_32

@ZhilkinSerg
Copy link
Contributor

I suggest renaming fonts.json to something like fonts.json.txt (and update instruction accordingly).

@Larwck Larwck changed the title [WIP] Graphical Overmap update Graphical Overmap update Jan 3, 2020
@Larwck Larwck marked this pull request as ready for review January 3, 2020 17:32
@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/no-sidebar-in-overmap-screen/22394/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Documentation> Design documents, internal info, guides and help. Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods Issues related to mods or modding SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants