Further expand regional terrains and work them into some map palettes #35836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-am-Erk
added
[JSON]
ZhilkinSerg
reviewed
Dec 7, 2019
Co-Authored-By: ZhilkinSerg <ZhilkinSerg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Further expands regional pseudoterrains and works them into some map palettes"Purpose of change
Regional terrains were added in #35627 and expanded in #35669. This powerful new feature needs some further expansion to be fully useful, eg. in the addition of new biome types, or for the rapid adjustment of the appearance of terrain types over all maps.
Describe the solution
Added t_region_groundcover_forest and _swamp
Added f_region_water_plant
Debated adding t_region_tree_swamp. Might still do it but I'm trying to think of a more elegant solution than that.
Converted occurrence of trees and grass and shrubs and flowers to regional equivalents in several map palettes, and will continue to do so. This adds some variance to maps, and standardizes the occurrence of long grass and stuff like that. Later, it will mean that a biome can specify different appearances, such as sand and dry earth.
Describe alternatives you've considered
There are infinite ways the terrains could be broken down.
There's some argument for keeping more specific appearances of things like t_tree, where one might want specifically an oak tree, but I don't think there are many of those and overall it would be better to ask for a shade tree and allow some random variation I think.
Testing
When it's done.