Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove professions with survivor armor & change Rescuer's armor #35844

Merged
merged 3 commits into from Dec 4, 2019
Merged

Remove professions with survivor armor & change Rescuer's armor #35844

merged 3 commits into from Dec 4, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2019

Summary

SUMMARY: Content "Remove professions with survivor armor & change Rescuer to non-survivor armor"

Purpose of change

Profession Removal: Was going to add armor substitutes to these professions if the No Survivor Armor blacklist was active, but Kevin has stated removing the four professions for being underpowered trash and not fitting to game lore is appropriate.
(Also they couldn't have made survivor armor with their tailoring levels)
Rescuer Armor Change: Rescuer with the No Survivor Armor mod active loses their rifle due to it being inside a survivor harness, and starts out almost nude. Same lack-of-skill-for-survarmor as removed professions.

Describe the solution

Remove Wasteland Ranger, Veteran bandit, Road Warrior, and Hardened Survivor. Change Rescuer's gear to fur armor.

Describe alternatives you've considered

None.

Testing

Removals: Started world as Hardened Survivor before changes, applied changes. Game keeps old title without throwing out error about invalid profession ID, but doesn't allow selection of removed profession again.
Rescuer: Loaded in.
image

Additional context

image
image

@ghost ghost changed the title Add substitute gear for professions with survivor gear if No Survivor Armor is enabled Remove Wasteland Ranger, Veteran Bandit, Road Warrior, and Hardened Survivor + Remove survivor armor from Rescuer Dec 4, 2019
@ghost ghost marked this pull request as ready for review December 4, 2019 00:36
@ghost ghost changed the title Remove Wasteland Ranger, Veteran Bandit, Road Warrior, and Hardened Survivor + Remove survivor armor from Rescuer Remove professions with survivor armor + Remove survivor armor from Rescuer Dec 4, 2019
@ghost ghost changed the title Remove professions with survivor armor + Remove survivor armor from Rescuer Remove professions with survivor armor & remove survivor armor from Rescuer Dec 4, 2019
@ghost ghost changed the title Remove professions with survivor armor & remove survivor armor from Rescuer Remove professions with survivor armor & change Rescuer's armor Dec 4, 2019
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Dec 4, 2019
@ZhilkinSerg ZhilkinSerg merged commit b40b704 into CleverRaven:master Dec 4, 2019
@ghost ghost deleted the NoSurvArmorSubs branch December 5, 2019 18:48
I-am-Erk pushed a commit to I-am-Erk/Cataclysm-DDA that referenced this pull request Dec 6, 2019
…erRaven#35844)

* Remove professions with survivor armor, change Rescuer to fur armor

* Remove obsoleted profs from scenario options

* Obsolete collections, give rescuer utility vest for magazines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants