Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12ga stocks and brass catcher fixes #35888

Merged

Conversation

tenmillimaster
Copy link
Member

@tenmillimaster tenmillimaster commented Dec 6, 2019

Summary

SUMMARY: Bugfixes "Shotgun sling, catcher and stock fixes"

Purpose of change

I errantly omitted the brass catchers from a number a shotguns (and slings), and also the wire stocks of the SPAS and the streetsweeper are removable, leading to issues with things like attaching a folding stock.

Describe the solution

Made the wire stocks irremovable, made the wire stock mod valid for shotguns, added the brass catcher and sling slots to appropriate shotguns.

Describe alternatives you've considered

None.

Testing

Loaded game and previewed shotguns in question in debug spawn.

Additional context

image
image
image
image
image
image
image

@ghost
Copy link

ghost commented Dec 6, 2019

Since the SPAS-12 stock is irremovable, the stock mount slot on the gun is unusable. Might want to change it to a regular stock slot just so it shows up visually without having to scroll all the way down to the bottom of the item description
(The Leadworks guns and the SKS do this already)

@ghost
Copy link

ghost commented Dec 6, 2019

Loaded in and tested the Cobray as well, no underbarrel slot for the forward grip or stock slot for the irremovable wire stock. shotgun_base having mounts for both instead of true mod slots is the culprit here.
image

@tenmillimaster
Copy link
Member Author

@laveyanfiend thanks, I'll get that fixed.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons labels Dec 6, 2019
@@ -50,7 +50,7 @@
"burst": 6,
"ups_charges": 1,
"reload": 200,
"valid_mod_locations": [ [ "accessories", 4 ], [ "sights", 1 ], [ "sling", 1 ], [ "rail mount", 1 ] ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason to remove sling slot here? Not that it's very useful to carry a gun that can't be fired unmounted on your back, but still.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know of any gatling guns that come with sling swivels?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. Though if the only issue is that it may lack sling swivels, guess I may later add a gunmod which allows attaching a sling on such unusual guns. Nevermind then.

@kevingranade kevingranade merged commit ab164b7 into CleverRaven:master Dec 9, 2019
@tenmillimaster tenmillimaster deleted the 12g-stock-and-brass-catchers branch September 20, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Gunmod / Toolmod Weapon and tool attachments, and add-ons [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants