Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supreme pizza #35924

Merged
merged 7 commits into from
Dec 10, 2019
Merged

Add supreme pizza #35924

merged 7 commits into from
Dec 10, 2019

Conversation

HipAndroid
Copy link
Contributor

Summary

SUMMARY: Content "Adds a recipe for a new pizza that uses a variety of ingredients."

Purpose of change

Rewards survivors who've scavenged, farmed, hunted, and foraged a wide variety of ingredients with a relatively resource intense source of joy and nutrition.

Describe the solution

Adds "Supreme Pizza" comestible and a new recipe found in Cucina Italiana.

Describe alternatives you've considered

Limiting toppings to more traditional toppings such as sausage and mushrooms.

Testing

Spawned pizza, ate it. Spawned Cucina Italiana and necessary components to craft the pizza, crafted it, ate it.

Additional context

This is my first PR! Started small to get a better grip on the system.

Adds a pizza with meat, cheese, and veggies.
extra open bracket
removed extra fluff
replaced tabs with spaces
@John-Candlebury John-Candlebury added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 7, 2019
Copy link
Member

@I-am-Erk I-am-Erk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fun score is out of whack. The rest looks good! Welcome to the wonderful world of cdda contributing.

data/json/items/comestibles/meat_dishes.json Outdated Show resolved Hide resolved
[ "dry_mushroom", 2 ],
[ "morel_cooked", 2 ],
[ "tofu", 2 ],
[ "dry_tofu", 2 ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the tofus would be better put on the meat list? In terms of recipe, they're more appropriate there.

[ "mushroom_cooked", 2 ],
[ "dry_veggy", 2 ]
],
[ [ "cheese", 2 ], [ "can_cheese", 2 ], [ "cheese_hard", 2 ] ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canned cheese on a pizza? get out of my kitchen and never come back.

(just kidding it's fine but don't do this in real life or your friends will all abandon you)

Changed location of tofu from veggie to meat list, removed looks like, and lowered fun value
whoops, that'll teach me to copy-paste all willy nilly with no regard for formatting
@ThomasLinkin
Copy link

almost there. keep it up my bro. welcome to the contribution

@ZhilkinSerg ZhilkinSerg merged commit 24490b7 into CleverRaven:master Dec 10, 2019
fengjixuchui added a commit to fengjixuchui/Cataclysm-DDA that referenced this pull request Dec 10, 2019
@HipAndroid HipAndroid deleted the SupremePizza branch December 11, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants