-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow "internal" wearables even with skin-contact gear on top #36062
allow "internal" wearables even with skin-contact gear on top #36062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done with a flag, not with a check for how many body parts it covers.
Could you explain? Isn't the "flag" the quantity of body parts being covered equaling 0? |
That's really unclear, and not visible to JSON contributors anywhere. Flags are both documented and clear to JSON contributors. |
Again, I don't follow. This automatically handles all items that don't cover any body parts. My understanding is power armor requires skin contact and therefore can only be worn over a certain body part when there is nothing covering it. Thus any item in existence now or created in the future would properly be compatible with power armor if it has no body parts coverage. What flag would you suggest and how would it not be redundant? |
I suggest you add a new flag.
This is not necessarily a good thing. A flag allows for selection, which is important here. |
Do you mean like putting an "under_the_skin" flag to an item like "mouthpiece" which technically covers "mouth" but really should be usable under power armor helmet? |
Yes, that could be one use case. |
Maybe just generalize it to "POWERAMOR_COMPATIBLE" flag? Not just under-the-skin things could be worn with power armor, I think; things like briefcases and shopping bags could be too. |
You need to document this flag. |
Co-Authored-By: BevapDin <tho_ki@gmx.de>
Co-Authored-By: BevapDin <tho_ki@gmx.de>
Getting failure: |
Wear ear plugs while wearing power armor
Summary
SUMMARY: Bugfixes "Adds ability to wear under-the-skin gear like ear plugs even with skin contact-demanding items like power armor."
Purpose of change
Make the game make sense by allowing one to wear earplugs underneath power armor.
Describe the solution
Just wear earplugs while wearing power armor. Before this, it was impossible.
Describe alternatives you've considered
Testing
Wore ear plugs under power armor. Other gear still cannot be worn over it.
Additional context