Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix travis errors #36204

Closed
wants to merge 1 commit into from
Closed

fix travis errors #36204

wants to merge 1 commit into from

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: none

Purpose of change

Try to fix the json errors caused by magiclysm.

Testing

stand by.

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) Mods: Magiclysm Anything to do with the Magiclysm mod labels Dec 17, 2019
@KorGgenT KorGgenT closed this Dec 18, 2019
@KorGgenT KorGgenT deleted the fix-travis branch December 18, 2019 00:16
@BevapDin
Copy link
Contributor

The code to test all mods just builds a list of the mods, and the test program simply loads them in the given order. Neither of them adds the "dda" mod, which is used to load the core game data.

This means the core game data (the skills etc.) isn't loaded at all, only the mods are loaded.

And the magic "module" checks the validness of the input (the skill ids) when it loads them. They don't exist because they have not been loaded because the core mod has not been loaded. Note: checking ids for validness should be done after everything has been loaded from JSON, as otherwise it requires that JSON is loaded in a specific order (in this case: skills before enchantments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants