Exclude dda in unit test mod list to fix CI build errors #36259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good for me. |
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
get_all_mods.pydoes not exclude theddacore content "mod", which causes dda to be loaded after other mods, which may be the cause the CI build is failing with invalid ids.Furthermore, the regional overlay of the Magiclysm mod makes the total field coverage exceeds 100, which is also fixed in this PR.
Describe the solution
Exclude "dda" from the list of mods in the unit test argument, and adjusted the field coverage values to reduce the total to 100. The error message for field coverage is also improved to show the individual values and the total value for easier debugging.
Testing
Waiting for the CI build to finish to see if it works.