Plural name fixes #36285
Merged
Plural name fixes #36285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data/json/items/armor.json
Outdated
| @@ -9869,7 +9870,7 @@ | |||
| "id": "case_violin", | |||
| "type": "ARMOR", | |||
| "name": "violin case", | |||
| "name_plural": "violin case", | |||
| "name_plural": "violin cases", | |||
curstwist
added
<Bugfix>
|
Can you please change these to use the new format for names, eg I know it's a pain but we're trying to move this way |
I think this is unrelated to the problem I am trying to solve in this PR. And I don't want to make these namings inconsistent within a single file. It would be better if the transition is made in separate PRs and in a whole file by whole file manner. |
|
Yeah, we can totally migrate to new format separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Translators pointed out several wrong plural names, such as
faux fur pantss,pair of C.R.I.T rec glovess, etc. because we did not explicitly define their plural names and our script will automatically append a suffixsin this case.Describe the solution
Explicitly define their correct plural names.