Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort gloves and shoes into seperate files from armor.json #36286

Merged
merged 3 commits into from Dec 22, 2019
Merged

Sort gloves and shoes into seperate files from armor.json #36286

merged 3 commits into from Dec 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2019

Summary

SUMMARY: Infrastructure "Move gloves and shoes out of armor.json"

Purpose of change

Armor.json is an amalgam of different clothing pieces and is slightly over 10,000 lines long. This is difficult to sort through and takes a while to lint.

Describe the solution

Move gloves and shoes out of armor.json into their own files.

Describe alternatives you've considered

Seperating more at once. Doing these first as there isn't much quibble room about these types of clothing being what they are.

Testing

Loaded world after reorganizing to see if load errors happened. None occured.

Additional context

@Jerimee
Copy link
Contributor

Jerimee commented Dec 20, 2019

Related (but not immediately relevant), it might be nice for the doc to include additional specifications on how these files ought to be organized.

I have almost no clue as to the where or why a given entity is included in one file versus another. Regularly updated files are confusing, and the organizational principles behind less popular files are completely inscrutable.

@ghost ghost marked this pull request as ready for review December 21, 2019 21:34
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Dec 22, 2019
@ZhilkinSerg ZhilkinSerg merged commit 8e58a85 into CleverRaven:master Dec 22, 2019
@ghost ghost deleted the HandsAndToes branch December 22, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants