Remove extras: field from overmap specialls #36298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please lint updated files. |
ZhilkinSerg
added
<Bugfix>
|
I simply don't know how to change Summary section for it to pass PR Validator, I tried numerous times :/ |
|
Remove the period at the end? |
|
Thank you so much :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix new fields map extras overwriting normal overmap terrain"Purpose of change
Prevent spawning field maps extras over normal map extras. This should fix #36273
Describe the solution
Remove
"extras": "field"from overmapjson'sleaving only the one ingeneric_open_landovermap_terain_hardcoded.json/Describe alternatives you've considered
None
Testing
I've created new world, and new player. Using teleport I moved to different locations checking if "field" extras like tall grass are being spawned (they are) and looking for any anomalies #36273 report describes. I was unable to find any such anomalies.