Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allsporting Group revamp #36308

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Conversation

LilShiningMan
Copy link
Contributor

SUMMARY: Infrastructure "slimmed down allsporting group in item_groups.json"

Summary

slimmed down allsporting group in item_groups.json

Purpose of change

There are entries in item_groups.json that are mostly composites of other item lists. Allsporting is a good example -- the bulk of the entry consists of most of the items (with some omissions) from both sports and camping lists. It makes sense to call groups rather than merely duplicate the entirety of them, as this reduces redundancy and makes it easier to add new items to a single group and have them spawn in various appropriate places automatically.

Describe the solution

Found entries from sports and camping, tallied up their combined weights for each group. Deleted entries and called both groups instead, weighted according to combined weights. Also, deleted one entry each from sports (linux t-shirt) and camping (duplicated entry for manual_survival). All told, 185 lines of redundant items were omitted.

Describe alternatives you've considered

Testing

linted entries and then debug spawned allsporting list.

Additional context

There were entries in sports not listed in allsporting but they were mostly items of clothing that are still appropriate. Camping had a greater number of items that had been omitted from the original list, but they mostly made as much sense as items that were included. There isn't going to be a huge difference in the actual spawned list.

slimmed down allsporting group in item_groups.json
@LilShiningMan
Copy link
Contributor Author

Is it possible to request a review of this? It looks like there was another Travis error, similar to the last. I don't think there's necessarily anything to fix here.

Copy link
Member

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error is not your fault, PR looks good to me.

@I-am-Erk I-am-Erk merged commit 39ca895 into CleverRaven:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants