Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY: Infrastructure "slimmed down allsporting group in item_groups.json"
Summary
slimmed down allsporting group in item_groups.json
Purpose of change
There are entries in item_groups.json that are mostly composites of other item lists. Allsporting is a good example -- the bulk of the entry consists of most of the items (with some omissions) from both sports and camping lists. It makes sense to call groups rather than merely duplicate the entirety of them, as this reduces redundancy and makes it easier to add new items to a single group and have them spawn in various appropriate places automatically.
Describe the solution
Found entries from sports and camping, tallied up their combined weights for each group. Deleted entries and called both groups instead, weighted according to combined weights. Also, deleted one entry each from sports (linux t-shirt) and camping (duplicated entry for manual_survival). All told, 185 lines of redundant items were omitted.
Describe alternatives you've considered
Testing
linted entries and then debug spawned allsporting list.
Additional context
There were entries in sports not listed in allsporting but they were mostly items of clothing that are still appropriate. Camping had a greater number of items that had been omitted from the original list, but they mostly made as much sense as items that were included. There isn't going to be a huge difference in the actual spawned list.