Add multiple layers support for map memory #36381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
ZhilkinSerg
force-pushed
the
refactor-map-memory
branch
5 times, most recently
from
0522560
to
ee44d41
Compare
ZhilkinSerg
force-pushed
the
refactor-map-memory
branch
from
8ac34ff
to
9148bcf
Compare
| @@ -174,7 +175,7 @@ struct level_cache { | |||
| float seen_cache[MAPSIZE_X][MAPSIZE_Y]; | |||
| float camera_cache[MAPSIZE_X][MAPSIZE_Y]; | |||
| lit_level visibility_cache[MAPSIZE_X][MAPSIZE_Y]; | |||
| std::bitset<MAPSIZE_X *MAPSIZE_Y> map_memory_seen_cache; | |||
| std::map<map_memory_layer, std::bitset<MAPSIZE_X *MAPSIZE_Y>> map_memory_seen_cache; | |||
There was a problem hiding this comment.
See #36392
I don't think we need multiple caches here, fundamentally both render modes render one tile at a time, so I think we can get away with just the one bit per tile.
|
In an ideal world, what I'd really like to happen is the player memorizes the actual map entities instead of symbols/tiles, but THAT requires pretty much starting from scratch wiring the feature up. |
|
Please also test if debug map preview is working correctly with the new map memory code. |
|
Will reopen after 0.E. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Add multiple layers support for map memory"Purpose of change
Allow fixing outstanding bugs with map memory. Combine Curses and Tiles code.
Describe the solution
Refactored map memory to store multiple layers.
Testing
Additional context
TODO:
.mmfiles;.mmfile;