Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove non-unwieldable weapons when limb breaks #36430

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Don't remove non-unwieldable weapons when limb breaks #36430

merged 1 commit into from
Dec 25, 2019

Conversation

Night-Pryanik
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Don't remove non-unwieldable weapons when limb breaks."

Purpose of change

Closes #36421 - Mono blade tumbles from you hand.

Describe the solution

Changed condition from !can_wield to can_unwield in apply_damage check for breaking limbs.

Describe alternatives you've considered

Remove such weapons from player when limb breaks.

Testing

Installed monomolecular blade, got HP of my both arms to 1, let zombie break them. Observed that no CBM is dropped.

Additional context

None.

@Night-Pryanik Night-Pryanik added Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Character / Player Character / Player mechanics labels Dec 25, 2019
@kevingranade kevingranade merged commit 5189297 into CleverRaven:master Dec 25, 2019
@Night-Pryanik Night-Pryanik deleted the dont-remove-non-unwieldable-weapons-when-limb-breaks branch December 25, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono blade tumbles from you hand. {Softlock}
2 participants