Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 100% spawns not spawning with low spawn density #36451

Merged
merged 2 commits into from
Dec 30, 2019

Conversation

Hirmuolio
Copy link
Contributor

@Hirmuolio Hirmuolio commented Dec 26, 2019

Summary

SUMMARY: Bugfixes "Make 100% spawns always spawn even with low spawn density"

Purpose of change

Fixes #36422

Describe the solution

The reduced spawn chance from low spawn density was applied too early resulting in 100% spawns not always spawning.

The reduced spawn chance is now checked only if unmodified spawn chance <100.

I also slightly changed how max_odds math is written. The math is same but. It is just is easier to read.

I also changed how spawning from group is handled. Instead of always spawning exactly one monster it will now spawn spawn_count * pack_size.get() monsters (in current use this is always one so this doesn't really change anything. Just makes behavior more consistent).

Describe alternatives you've considered

Testing

Set spawn density to 0.1 and the warehouse boss did spawn.

Additional context

This will probably affect other spawns too in other places where low spawn density caused no monsters to spawn sometimes. Based on code the fixed behavior is the intended way to work.

@Hirmuolio Hirmuolio changed the title move no spawn condition Fix 100% spawns not spawning with low spawn density Dec 26, 2019
@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map labels Dec 27, 2019
@kevingranade kevingranade merged commit 73660c1 into CleverRaven:master Dec 30, 2019
@Kodiologist
Copy link
Contributor

Noice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spawn rates lower than the default can make Clear Back Bay impossible
4 participants