Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style regression and unit test warnings #36505

Merged
merged 1 commit into from
Dec 28, 2019

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Dec 28, 2019

Summary

SUMMARY: None

Purpose of change

Fix errors in the CI build.

Describe the solution

  1. Styled weather.cpp
  2. Suppressed the warning about unvisited "tiles-new" members in the JSON files. These members are only accessed when loading the tileset, so the unit test could not reach them.

Testing

Ran the unit test and no warnings were reported.

@KorGgenT KorGgenT added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Dec 28, 2019
@BevapDin BevapDin merged commit c886711 into CleverRaven:master Dec 28, 2019
@Qrox Qrox deleted the fix-ci-build branch December 29, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants