Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translation::serialize #36545

Closed
wants to merge 1 commit into from

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: Features "adds translataion::serialize member"

Purpose of change

This is to make it more accessible to serialize translations. this serialize shall be used in the nested container series of PRs, but this is a standalone feature.

Testing

serialize and deserialize functions

@KorGgenT KorGgenT added [JSON] Changes (can be) made in JSON [C++] Changes (can be) made in C++. Previously named `Code` labels Dec 30, 2019
@Qrox
Copy link
Contributor

Qrox commented Dec 30, 2019

I don't think serializing a translation is a good idea. Once the original string in the code/json files changes, the serialized translation won't translate correctly, as the po files will no longer contain the serialized strings.

@KorGgenT
Copy link
Member Author

i can see this also being needed to be addressed for artifacts as well, so what might you suggest instead?

@Qrox
Copy link
Contributor

Qrox commented Dec 30, 2019

Ideally all persistent information needed to generate an artifact's name should be saved, for example, random seeds or snippet ids, which are persistent through the game's changes. Or you can just follow the current approach for artifact names, that is saving the name as a translated string, and loading the name and call no_translation with it to construct a translation object.

@KorGgenT
Copy link
Member Author

well you've convinced me i think. i'm not sure what i'm going to do about artifacts specifically, but i'm just going to remove the ability to specify the names of pockets in nested containers until some future date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants