-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First two wizard towers for Magiclysm #36588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-am-Erk
added
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: Magiclysm
Anything to do with the Magiclysm mod
labels
Dec 31, 2019
This was referenced Jan 5, 2020
I-am-Erk
changed the title
WIP: Wizard towers for Magiclysm
First two wizard towers for Magiclysm
Jan 9, 2020
KorGgenT
reviewed
Jan 9, 2020
KorGgenT
reviewed
Jan 9, 2020
KorGgenT
reviewed
Jan 9, 2020
Co-Authored-By: Curtis Merrill <curtis.r.merrill@gmail.com>
Woops, I forgot to fix that on the git version. Done. |
Sure was. I added the shower as an afterthought and forgot to check if that letter was already used. As dumb a mistake as you might expect for having showers appear everywhere. |
ZhilkinSerg
reviewed
Jan 10, 2020
"vision_night": 30, | ||
"anger_triggers": [ "PLAYER_CLOSE", "HURT" ], | ||
"regenerates": 10, | ||
"death_drops": { "item": "plastic_chunk", "prob": 100, "count": [ 5, 10 ] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe count
is not allowed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[JSON]
Changes (can be) made in JSON
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: Magiclysm
Anything to do with the Magiclysm mod
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Adds wizard towers to magiclysm."
Purpose of change
@KorGgenT asked me to make some wizard towers for magiclysm.
Describe the solution
This adds wizard tower 1, a normal house that happens to also be a stone wizard tower with a golem lab.
It adds plastic golems, a low-power but still formidable golem that can regenerate.
It also adds some furniture for magiclysm for wizard studies: an orrery, a standing alembic, magic work benches, and a huge mana crystal that glows.
Describe alternatives you've considered
I plan to add wizard tower 2, an office building style tower, and wizard tower 3, an improbably tall workshop.
EDIT: The office tower design isn't working so well, so I've changed it to a wizard tower that's also a house, a wizard tower that is mainly a workspace, and I'll probably build a third tower that belongs in the wilderness - but that might be a different PR.
Testing
I have been testing this in game as I go.