Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable erroneous old-style-cast warning #36655

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

The Clang 6 CMAKE build target still reports a warning when this signal handler is invoked, see https://travis-ci.org/CleverRaven/Cataclysm-DDA/jobs/631788126

Describe the solution

Add pragmas to tell both GCC and clang to ignore this warning just at this location.

Describe alternatives you've considered

If this doesn't work we could disable this warning entirely just for this build target as it is the only place it is happening.

Testing

Using PR to test that I haven't broken something extremely basic, if that works the only simple way to verify is to push to master and check that the failing target starts succeeding.

@kevingranade
Copy link
Member Author

I'm going to go ahead and push this to find out if it resolves the problem.

@kevingranade kevingranade merged commit fe72505 into master Jan 3, 2020
@kevingranade kevingranade deleted the kevingranade-no-old-style-cast-warning branch February 25, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant