Jsonize swim speed mutation modifier as per walk cost mutation modifier #36678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Jsonize swim speed mutation modifier as per walk cost mutation modifier"
Purpose of change
Jsonize swim speed mutation modifier so new mutations can make use of it, instead of checking for specific mutations in swim_speed() in player.cpp
there is already movecost_modifier member for mutations that apply a modifier to walk speed calculations, so its consitent to have swim speed behave the same instead of flat reductions per specific mutations.
Describe the solution
jsonize the movecost_swim_modifier and add to applicable mutations, load it ingame, and then modify swim_speed() to apply that multiplier.
Describe alternatives you've considered
N/A
Testing
Tested and got similar results to what currently happens with swim speed with the flat modifier checks for fins and scales etc.
Additional context
N/A