Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonize swim speed mutation modifier as per walk cost mutation modifier #36678

Merged
merged 1 commit into from Jan 4, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 3, 2020

Summary

SUMMARY: Features "Jsonize swim speed mutation modifier as per walk cost mutation modifier"

Purpose of change

Jsonize swim speed mutation modifier so new mutations can make use of it, instead of checking for specific mutations in swim_speed() in player.cpp
there is already movecost_modifier member for mutations that apply a modifier to walk speed calculations, so its consitent to have swim speed behave the same instead of flat reductions per specific mutations.

Describe the solution

jsonize the movecost_swim_modifier and add to applicable mutations, load it ingame, and then modify swim_speed() to apply that multiplier.

Describe alternatives you've considered

N/A

Testing

Tested and got similar results to what currently happens with swim speed with the flat modifier checks for fins and scales etc.

Additional context

N/A

@kevingranade
Copy link
Member

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/swim-speed-moddifiers/22382/8

@kevingranade kevingranade merged commit 5575599 into CleverRaven:master Jan 4, 2020
@ghost ghost deleted the swim_mut branch January 17, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant