Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon camp NPC talk and bulletin board mission #36697

Merged
merged 7 commits into from Jan 7, 2020
Merged

Abandon camp NPC talk and bulletin board mission #36697

merged 7 commits into from Jan 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 4, 2020

Summary

SUMMARY: Features "Abandon camp NPC talk and bulletin board mission"

Purpose of change

Allow camps to be abandoned, all the buildings remain, and its much the same as just walking away, but some people may prefer it for neatness sake.

It also removes the camp from the overmapbuffer and submap, so a new camp could then be built nearby, perhaps in a slightly more advantageous position.

Describe the solution

add talk function and camp mission to abandon it, recall all workers, reassign all camp-assigned workers.

Describe alternatives you've considered

N/A

Testing

Talked to NPC at camp, asked them to abandon camp, it disappeared off hte overmap, and the bulletin board was not functional, and workers were recalled.

Tried the altenrative method of activcating the bulletin board mission to abandon camp, and the same happened.

Additional context

This is kinda pointless imo, if you dont want the camp there, just like .. walk away and forget about it, but a few people now have expressed the desire for this feature, so here it is :P

@Fris0uman
Copy link
Contributor

What happens if you try to make a new camp on site of the old one?

@ghost
Copy link
Author

ghost commented Jan 4, 2020

What happens if you try to make a new camp on site of the old one?

The camp overmap terrain is stil llisted as "camp survey" , I'm not sure a memory is kept of what overmap terrain it was before.

But - now if they make a new camp, there will no longer be the thing stopping them of " there is already another camp nearby ".

All the buildings will still be there, depending on how upgraded the camp was, and if this overlaps with a new camp, the new camp will likely jsut overwrite and merge with th eold buildings, same as if you build a construction then upgrade your camp where the construction is.

I.e its not ideal, but if people really wanna move their camp next door, and make a new one, or neaten up their menus and maps and stuff by removing something unwanted, then they can now, it wont exist as a basecamp structure in the data anymore.

src/faction_camp.cpp Outdated Show resolved Hide resolved
Co-Authored-By: Anton Burmistrov <Night_Pryanik@mail.ru>
src/faction_camp.cpp Outdated Show resolved Hide resolved
src/npctalk_funcs.cpp Outdated Show resolved Hide resolved
davidpwbrown and others added 2 commits January 4, 2020 23:16
Co-Authored-By: BevapDin <tho_ki@gmx.de>
Co-Authored-By: BevapDin <tho_ki@gmx.de>
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` Player Faction Base / Camp All about the player faction base/camp/site labels Jan 6, 2020
@ZhilkinSerg ZhilkinSerg merged commit 88009f4 into CleverRaven:master Jan 7, 2020
@ghost ghost deleted the abandon_camp branch January 17, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants