WIP: Crafting recipes wrap-up #36720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed nesting of accessory groups from the itemgroup "accesories_personal_unisex" into their own defined groups so that mods can directly add to them when adding jewellery spawning in a natural manner that doesn't overlap. All weightings kept intact, working as normal, except to add a secondary group for earrings so that any of the three different metal variants with the new gemstones can appear as unisex clothing. Grills left as original until the new grills are balanced for rarity.
Fixing errors, I'm so sorry.
Last one I hope
Linted. Should be the last, I'm so sorry, first PR.
adds more items made of titanium to act as sources and uses for titanium in the game
adds a harvest json to facilitate being able to extract implants during human and zombie dissection
Adds titanium items to relevant spawn lists with appropriate weighting, also specifically making sure that the ultra-light frames and titanium scrap that already exist in Aftershock have a chance to exist outside of just the one bike that Aftershock adds and the golf club as a disassembly product.
afs_titanium_scrap was far, far lighter than its volume insinuated for what is assumed to be a solid chunk of the metal (as with other metals). afs_titanium_frame left as is because it follows existing frame conventions.
Fleshes out the disassembly of titanium items to provide more sources of the relatively rare titanium material. Adds an apparently unprecedented disassembly recipe for the titanium frame.
Allows afs_scrap_titanium to be crafted from afs_titanium_small, and adjusts the scrap required to construct a frame to properly reflect the weight values and as a balance to the general scarcity of the material.
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
It belongs in weapons
Previously had it adjusted for smaller default charge numbers and was throwing an error
It's throwing an error, removing until I figure out why. It was an afterthought anyway.
issue was a typo with two words in wrong order
Addresses the string problems with only one space after a period per Travis CI's error report.
Missed a double space
Required addition due to my repo being out of date and one of the files I worked on being changed since putting this PR out.
Titanium was white in aftershock, despite titanium not necessarily being lighter in colour or sheen than silver or platinum, which are both represented by light_gray in the game. Brings the original scrap and titanium frames to parity with the new items, providing consistency across the board.
|
One thing to note is that by changing some of these to welding standard, the electric forge will no longer be a potential tool for the updated recipes- however, all of the vehicle part recipes in this |
The soldering standard uses solder which is great for consistency across electronic manipulation, but welding was being used instead of soldering and relevant gun modifications and use, despite the firearm kits being apparently synonymous with welders for these purposes? Did not make sense, so created this standard. I realise belatedly that they probably won't be applicable for jewellery standards.
Welders were being treated as synonymous with both the small and large repair kits, despite the closest metalworking tool they contain being the soldering iron. There are also gross inconsistencies in the charge use of the repair kits, being that the use was predominately meant to be use of a soldering iron and were somehow measured against welder use. The new fine_metalworking_standard was made in requirements prior to this change, and consistency has been greatly improved across all recipes in this json. Some might still be able to use some work, but this should bring everything onto the same page, and reduce the number of lines necessary to do so.
|
The weapon re-wrap has been messy. I've gauged intended use of different fields from developers, and asked for feedback in providing consistency across gun and accessory recipes that are plausible and consistent with one another, without upsetting in-game norms or balance. Additionally it has brought attention to the fact that the welding rig vehicle part provides a soldering iron for crafting purposes, but can no longer use it as an interaction. This leaves vehicle parts without an accessible welder for small repairs that a welder cannot interact with, I've added this to my to-do list for a different PR. |
There was quite a bit of inconsistency here just in formatting alone, particularly where `"using":` had attempted to be used early on in terms of positioning, and later for flame-related chemical stuff, just all over the place and left over unnecessary text. Besides that, a new standard was added to `toolsets.json` requirements, glassblowing. It only sees one use here, but will be a lot more relevant in later files when glass recipes come up.
Aforementioned addition of glassblowing standard from previous commit.
Not as many lines saved here as thought, largely already formatted and many of the recipes are nitpicky and not able to be standardized, or if there is some consistency, the inability for `"using":` to have OR instead of AND between entries limits functionality. New `glassblowing_standard` is used here, and some soldering iron changes where solder being used didn't make as much sense have been changed to `fine_metalwork_standard`- not sure if that sits well being able to commandeer a repairkit for its soldering iron, but there it is for now.
|
That should do it for the first pass of the recipes folder itself excepting |
barely worth doing, but changed the lists used in `"tools":` to `"using":`
Just a couple of recipes in here.
|
Going to attempt this fresh as by the time I figured out how to do some of the things better, the half-baked changes were already too far in on my side of it. Cleaned my repo, will make a second pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "Wraps-up crafting recipes to use requirements in all applicable cases.'"Purpose of change
There are instances of recipes left in the code that have not been modernized to use requirements when applicable, meaning there is room for optimization.
Describe the solution
Modernizes various recipe json's in order catch the few recipes that have not been updated to use requirements, reducing the total number of characters needed to represent multiple possible entries.
Describe alternatives you've considered
Leaving as is. I thought it would be good practice on a small scale and helpful to tackle something minor like this.
Testing
Currently testing all changes on my own game to make sure all changes reflect the original recipes and detect errors. Linting as I go along, as well as checking astyle requirements.
Additional context
Got the idea from the wiki regarding
Help-with-development-(List-of-easy-jobs).