Refactor monsters shift-v menu #36722
Conversation
Update forked repo
Update forked repo
Update forked repo
…nsters-shift-v-menu
8street
changed the title
curstwist
added
[C++]
…nsters-shift-v-menu
|
Would it be possible to color code the monster names as well? I often find myself wishing for that. |
How would you like to coloring the names of the monsters? In relation to the player, for example, hostile monsters are red? Or do you just want to highlight the name with a different color? Please provide an example. Note that all changes a colors of monsters here will remain in the monsters shift-v menu. For global coloring of monster names, please create a topic in the Issues. Maybe someone will make your request. |
In the "compass" view, monster names are shown from gray for the lowest level monsters, through white for slightly more dangerous ones, then pink, all the way through to bright red which is the highest Ive personally seen. I often see a dangerous monster by spotting the color, then hit shift+V, wanting to know its location, but when looking at the list I realise I didn't actually notice the name of the monster, just the color, so I have to leave the shift+V menu, match the color with a name from the compass, then reopen the shift+V menu to find the right zombie. |
|
Well, monsters menu look better. Also I'd added coloring of the monster's name in the monster info window. |
|
Should incorporate 3d field of vision? |
Thx for testing. Fixed. |
|
With your latest improvements on directions labels the PR should also close #31618. |
|
Could you please provide a screenshot with more terminal height? Say, 50-60? |
|
|
Maybe I will need to make a new PR, where the all blue color be brighter. This is not the first time that blue is not clear visible. |
You mean blue-on-black names like Z-9? |
Yes. You have no problems reading such blue text? |
|
I do have problems with that combination of colors, and I'll appreciate if you change them to, say, light blue on black. But that would be better implemented in separate PR. |
* Editing game.cpp * Editing game.cpp 2 * Editing game.cpp 3 * Editing game.cpp 4 * Editing game.cpp 5 * Astyle * To satisfy Clang-tidy build * Coloring monster names and some fix * Some polishing * Fix npc info * Another fix * Fix long 3d vision directions text * Fixed CleverRaven#24436 Based on commit 2657814 by 8street, originally merged into mainline by KevinGranade.
Summary
SUMMARY: Bugfixes "Refactor monsters shift-v menu"Purpose of change
The monsters shift-v menu does not look very good.
Describe the solution
Changes in monsters shift-v menu:
Describe alternatives you've considered
Do nothing.
Testing
Before
After
